Skip to content

Follow-up from "feat(home): Redesign landing page"

The following discussions from !824 (merged) should be addressed:

  • @oregand started a discussion: (+10 comments)

    @axil @jeldergl @tauriedavis

    Hey team!

    I have pushed the latest round of changes with some color, font and spacing updates.

    Can you let me know what you think? I have tried to get as close to the design as possible without writing extra CSS and using utility classes but I think I might need to finish the last few bits with extra CSS(see below):

    Known Issues:

    • Spacing inside first "Select a product area" panel between image and text does not match designs. Is what I have an acceptable tradeoff to let us keep using the utility classes?
    • Some of the spacing is slightly different to the designs as I have been trying to use the utility classes.
  • @jeldergl started a discussion: (+6 comments)

    I’m attaching some redlines. They can tend to be a bit nit-picky, but overall lots of minor things.

    I added reference links to several places in the annotations, so I would recommend viewing the live redlines in Figma to access the reference links.

    Home_-_redlines

  • @ekigbo started a discussion: (+1 comment)

    Minor: Can this check be moved to a function? is_production or similar

  • @ekigbo started a discussion: (+1 comment)

    Possibly a follow up, but could this be some kind of repeated block that takes a few paramters? Looks this block and the next few have more or less the same structure.

  • @jerasmus started a discussion: (+2 comments)

    Non-blocking since I know this codebase doesn't follow our style guide completely yet, but I think we prefer named sectors rather than tag selectors.

Edited by Achilleas Pipinellis