Loading
Skip gitlab-shell bundle install when Gemfile is absent
What does this MR do and why?
Contributes to gitlab-shell#877 (closed)
Problem
gitlab-shell is removing its Ruby Gemfile and Gemfile.lock, which
would cause gdk install and gdk update to fail when the bundle
target runs. GDK must continue supporting older gitlab-shell versions
that still have a Gemfile.
Solution
- Run
support/bundle-installonly when gitlab-shell has aGemfile. - Print a skip message and succeed when the
Gemfileis absent. - Touch the bundle stamp after either successful path while preserving bundler failures.
How to set up and validate locally
- Check out the gitlab-shell branch
877-remove-ruby-gemfileingitlab-shell/. - Run
make gitlab-shell-setuporgdk update. - Verify that the skip message is printed and the command succeeds.
- On gitlab-shell
main, verify that the install message is printed.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Vasilii Iakliushin