Draft: Swh/improve dn code

Sangwoo Hanrequested to merge
swh/improve-dn-code into main

What does this merge request do and why?

Follow up from gitlab-com/gl-infra/tenant-scale/cells-infrastructure/team#546 (closed)

Minor code improvements

How to set up and validate locally

  1. Make sure cells.instance_count is set to 1 and that gdk/gitlab-topology-service is running.
  2. Open rails console in gdk/gitlab.
  • 1A) Run cell_service = Gitlab::TopologyServiceClient::CellService.new
  • 1B) Run cell_service.get_cell_info
  • 1C) Verify you get:
=> <Gitlab::Cells::TopologyService::CellInfo: id: 1, address: "127.0.0.1:3333", session_prefix: "cell-1", sequence_range: <Gitlab::Cells::TopologyService::SequenceRange: minval: 0, maxval: 0>, sequence_ranges: [<Gitlab::Cells::TopologyService::SequenceRange: minval: 1, maxval: 9223372036854775807>]>
  1. Open rails console in gdk/gitlab-cells/cell-2/gitlab.
  • 2A) Run cell_service = Gitlab::TopologyServiceClient::CellService.new
  • 2B) Run cell_service.get_cell_info
  • 2C) Verify you get:
=> <Gitlab::Cells::TopologyService::CellInfo: id: 2, address: "127.0.0.1:12002", session_prefix: "cell-2", sequence_range: <Gitlab::Cells::TopologyService::SequenceRange: minval: 0, maxval: 0>, sequence_ranges: [<Gitlab::Cells::TopologyService::SequenceRange: minval: 100000000001, maxval: 200000000000>]>

Merge request reports