Replace hardcoded /home/git/gdk in tests

What does this merge request do and why?

Tests use hardcoded /home/git/gdk where they should be using actual location of the test environment, or use mocked value.

For now the mocked value is accessible though config.gdk_root.

More info

GDK_ROOT seems to reference two separate things:

  1. root of GDK source code, so that scripts can locate their libs (proposal: GDK::SRC)
  2. root of GDK runtime data, with checkouts of dependencies, etc. (proposal: set dynamicall and stored in config.gdk_env)

The follow-up issue #2624 to discuss the proposal.

Tests probably need only the second one. In case of Cells we probably have GDK::SRC != config.gdk_env.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  • ensure /home/git/gdk doesn't appear in specs
rg "/home/git/gdk" spec

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
Edited by Anatoli Babenia

Merge request reports

Loading