Skip to content

Refactor Shellout and move inside GDK

Gabriel Mazetto requested to merge brodock/refactor-shellout into main

What does this merge request do and why?

Ideally no code should live outside of the GDK module to avoid conflicts with other code being loaded (for example from other gems).

This refactors the Shellout code that lives outside of GDK module, and move it to be inside, and make some quality of life improvements:

  1. Move Shellout to be inside GDK module
  2. Refactor Shellout usages
  3. Introduce ShelloutHelper for specs

How to set up and validate locally

There is no change in behavior. Test coverage should be enough.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Gabriel Mazetto

Merge request reports

Loading