Skip to content

Execute make dependencies before creating config files

What does this merge request do and why?

Execute Makefile targets specified in make_dependencies before creating config files.

Related to #2138 (closed)

How to set up and validate locally

  1. git checkout naohashizume/execute-make-dependencies-before-config
  2. rm -rf gitlab-http-router
  3. rake reconfigure
  4. See that gitlab-http-router/wrangler.toml was created
  5. make gitlab-http-router-setup

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Nao Hashizume

Merge request reports