Skip to content

Add support for tty-spinner in rake

Kev Kloss requested to merge kkloss-move-make-update-to-rake-tasks into main

What does this merge request do and why?

This MR adds support to replace the long log output with a list of fancy loading spinners in gdk update using tty-spinner. Note: It does not enable them yet. We’ll do that in a follow-up MR.

The output is stored in log files per rake task and timestamp in the ./log/rake/ directory. If an error occurs, the log file of the rake task that raised the error is shown to the user.

A gdk-performance follow-up to introduce parallelization is being worked on in !3726 (merged).

Demo

Success Error
2024-07-12_spinner-fancy 2024-07-12_spinner-fancy-error

How to set up and validate locally

  1. In lib/tasks/update.rake, change task update: to spinner_task update:
  2. Run GDK_SELF_UPDATE=0 gdk update
  3. Check that the update was successful and correct

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Kev Kloss

Merge request reports

Loading