Disable request buffering for new SSH endpoints
What does this merge request do and why?
Contributes to gitlab#466160 (closed)
Problem
While testing the new implementation of SSH endpoints for git related actions. I noticed a problem reproducible in my local environment.
The request from GitLab-Shell to Workhorse was hanging. After in investigation I discovered the root cause of this problem.
In our NGINX configuration we use request buffering. After adding the new endpoint to the list of exceptions, then problem was resolved.
Solution
Add new endpoints to the list of exceptions for nginx configuration.
Routes in Rails app: https://gitlab.com/gitlab-org/gitlab/-/blob/329864c14648583ddf4158f1025f6b12551b79c8/config/routes/git_http.rb#L13-14
How to set up and validate locally
New endpoints are not ready yet. But I think the change is straightforward.
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.