Only prepend asdf paths in case asdf is enabled
What does this merge request do and why?
Given you have asdf installed
When you opt out of asdf in the gdk
Then the PATH variable should not be prepended with asdf paths
How to set up and validate locally
- Disable asdf:
gdk config get asdf.opt_out true - Create a directory
~/not-working/shims - Create a file:
{ echo '#!/usr/bin/env bash' echo '' echo 'echo "I do not work"' echo 'exit 1' } > ~/not-working/shims/gem - Make it executable:
chmod a+x ~/not-working/shims/gem export ASDF_DATA_DIR="~/not-working"- Run
make platform-update-timed
Before the above should fail, afterwards it should be alright.
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctortest added, if needed. -
Add the ~highlightlabel if this MR should be included in theCHANGELOG.md.
Edited by Lukas Eipert