Add asdf-install target for gitlab-elasticsearch-indexer
What does this merge request do and why?
This MR introduces gitlab-elasticsearch-indexer-asdf-install
target.
Related to #1635 (closed)
How to set up and validate locally
git checkout 1635-asdf-install-in-gitlab-elasticsearch-indexer
gdk config set elasticsearch.enabled true
gdk reconfigure
--------------------------------------------------------------------------------
Installing asdf tools from /src/gdk/gitlab-elasticsearch-indexer/.tool-versions
--------------------------------------------------------------------------------
golang 1.21.4 is already installed
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Merge request reports
Activity
changed milestone to %16.7
added Category:GDK Engineering Productivity Quality featureenhancement gdk-reliability gdk-usability typefeature + 1 deleted label
assigned to @nao.hashizume
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer None @mattkasa
(UTC-8, 18 hours behind author)
@tigerwnz
(UTC+8, 2 hours behind author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 53 commits
-
5b6a1a49...221d3cc8 - 52 commits from branch
main
- f156533b - Add asdf-install target for gitlab-elasticsearch-indexer
-
5b6a1a49...221d3cc8 - 52 commits from branch
Hi @ashmckenzie, could you please review when you get back from OOO? Thanks!
Edited by Nao Hashizumerequested review from @ashmckenzie
changed milestone to %16.8
added 1 commit
- d20d1837 - Add asdf-install target for gitlab-elasticsearch-indexer
added 1 commit
- 26b60c84 - Add asdf-install target for gitlab-elasticsearch-indexer
- Resolved by Ash McKenzie
mentioned in commit 88c32310