Skip to content

Fix gitaly service name in Procfile template

David Fernandez requested to merge 10io-fix-gitaly-service-name-procfile-template into main

🌳 Context

It seems that Initial support for gitaly server-side backups (!3289 - merged) introduced changes in the Procfile.erb file for gitaly.

The problem is that some spaces have been introduced in front of the line:

Screenshot_2023-09-04_at_09.40.44

This cascades into gdk status using gitaly as the service name:

$ gdk status

down: /Users/david/projects/gitlab-development-kit/services/  gitaly: 712s; run: log: (pid 71494) 712s
down: /Users/david/projects/gitlab-development-kit/services/gitlab-workhorse: 712s; run: log: (pid 71488) 712s
run: /Users/david/projects/gitlab-development-kit/services/postgresql: (pid 71497) 712s, normally down; run: log: (pid 71487) 712s
down: /Users/david/projects/gitlab-development-kit/services/rails-background-jobs: 712s; run: log: (pid 71492) 712s
down: /Users/david/projects/gitlab-development-kit/services/rails-web: 712s; run: log: (pid 71489) 712s
run: /Users/david/projects/gitlab-development-kit/services/redis: (pid 71496) 712s, normally down; run: log: (pid 71491) 712s
down: /Users/david/projects/gitlab-development-kit/services/webpack: 712s; run: log: (pid 71493) 712s

=> GitLab available at http://gdk.test:8000.
=>   - Ruby: ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [arm64-darwin22].
=>   - Node.js: v18.17.0.

🤔 What does this merge request do and why?

  • Remove the spaces in front of gitaly in the Procfile.erb

⚙ How to set up and validate locally

With this MR

  • gdk reconfigure
  • gdk status gives:
$ gdk status
run: /Users/david/projects/gitlab-development-kit/services/gitaly: (pid 9775) 19s, normally down; run: log: (pid 8888) 22s
down: /Users/david/projects/gitlab-development-kit/services/gitlab-workhorse: 22s; run: log: (pid 8883) 22s
run: /Users/david/projects/gitlab-development-kit/services/postgresql: (pid 8892) 22s, normally down; run: log: (pid 8887) 22s
down: /Users/david/projects/gitlab-development-kit/services/rails-background-jobs: 22s; run: log: (pid 8889) 22s
down: /Users/david/projects/gitlab-development-kit/services/rails-web: 22s; run: log: (pid 8885) 22s
run: /Users/david/projects/gitlab-development-kit/services/redis: (pid 8891) 22s, normally down; run: log: (pid 8882) 22s
down: /Users/david/projects/gitlab-development-kit/services/webpack: 22s; run: log: (pid 8884) 22s

=> GitLab available at http://gdk.test:8000.
=>   - Ruby: ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [arm64-darwin22].
=>   - Node.js: v18.17.1.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • [-] Documentation added/updated, if needed.
  • [-] Announcement added, if change is notable.
  • [-] gdk doctor test added, if needed.
  • [-] Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Merge request reports