Remove chromedriver from GDK Brewfile
What does this merge request do and why?
Since spec/features
and the qa/
tests automatically download chromedriver, perhaps we no longer need to require it to be installed to update GDK?
How to set up and validate locally
brew uninstall chromedriver
gdk update
- Delete any existing chromedriver installs, e.g:
/Users/jmccure/.cache/selenium/chromedriver/mac-arm64/114.0.5735.90/
rspec spec/features/issues/user_creates_branch_and_merge_request_spec.rb:119
cd qa
- Delete any existing chromedriver installs, e.g:
/Users/jmccure/.cache/selenium/chromedriver/mac-arm64/114.0.5735.90/
QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb
- Browser should open for both types of tests
Impacted categories
The following categories relate to this merge request:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Merge request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise an issue to follow-up. -
Documentation added/updated, if needed. -
Announcement added, if change is notable. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Edited by Jay McCure