Skip to content

Remove chromedriver from GDK Brewfile

Jay McCure requested to merge jay_mccure-main-patch-72995 into main

What does this merge request do and why?

Since spec/features and the qa/ tests automatically download chromedriver, perhaps we no longer need to require it to be installed to update GDK?

How to set up and validate locally

  1. brew uninstall chromedriver
  2. gdk update
  3. Delete any existing chromedriver installs, e.g: /Users/jmccure/.cache/selenium/chromedriver/mac-arm64/114.0.5735.90/
  4. rspec spec/features/issues/user_creates_branch_and_merge_request_spec.rb:119
  5. cd qa
  6. Delete any existing chromedriver installs, e.g: /Users/jmccure/.cache/selenium/chromedriver/mac-arm64/114.0.5735.90/
  7. QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/ee/browser_ui/3_create/repository/assign_code_owners_spec.rb
  8. Browser should open for both types of tests

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Jay McCure

Merge request reports