Only pick executables that are files

Stan Hurequested to merge
sh-find-exectuable-ensure-file-is-file into main

What does this merge request do and why?

For macOS, having a /opt/homebrew/opt in the PATH would cause the GDK to erroneously pick /opt/homebrew/opt/git as the binary path. We can avoid this by ensuring that executable is a file, not a directory.

How to set up and validate locally

  1. Run export PATH=/opt/homebrew/opt:$PATH
  2. Run gdk reconfigure.

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Stan Hu

Merge request reports