Skip to content

Use explicit external_k8s_proxy_url

Hordur Freyr Yngvason requested to merge use-explicit-k8s-proxy-url into main

What does this merge request do and why?

GitLab rails has legacy code path that derives external_k8s_proxy_url from external_url. GDK still relies on this logic, which is not correct as the proxy may not be listening there (for example, when nginx is disabled).

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Impacted categories

The following categories relate to this merge request:

Merge request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise an issue to follow-up.
  • Documentation added/updated, if needed.
  • Announcement added, if change is notable.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Merge request reports