Add workaround in ESLint version detection in Code Quality (0.85.26)
What does this Merge Request do and why?
Adds a workaround in ESLint version detection in Code Quality (0.85.26 at least).
As !2002 (merged) introduced package.json
without eslint
, this bug became apparent.
before
https://gitlab.com/gitlab-org/gitlab-development-kit/-/jobs/2666147171
$ docker run --rm \ # collapsed multi-line command
sh: null: out of range
WARNING: A new version (v0.85.29) is available. Upgrade instructions are available at: https://github.com/codeclimate/codeclimate#packages
WARNING: A new version (v0.85.29) is available. Upgrade instructions are available at: https://github.com/codeclimate/codeclimate#packages
after
https://gitlab.com/gitlab-org/gitlab-development-kit/-/jobs/2673829063
$ rm -f package.json
$ echo "Removing package.json only in this CI job to work around a limitation of Code Quality 0.85.26"
Removing package.json only in this CI job to work around a limitation of Code Quality 0.85.26
[...]
$ docker run --rm \ # collapsed multi-line command
WARNING: A new version (v0.85.29) is available. Upgrade instructions are available at: https://github.com/codeclimate/codeclimate#packages
WARNING: A new version (v0.85.29) is available. Upgrade instructions are available at: https://github.com/codeclimate/codeclimate#packages
Merge Request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. - [n/a] Tests added for new functionality. If not, please raise Issue to follow-up.
- [n/a] Documentation added/updated, if needed.
- [n/a]
gdk doctor
test added, if needed. - [n/a] Add the
~highlight
label if this MR should be included in theCHANGELOG.md
.
Closes #1517 (closed)
Edited by Takuya Noguchi