Skip to content

Allow adding custom domain for pages by default

Vishal Tak requested to merge pages-gdk-domain-setting into main

What does this Merge Request do and why?

Pages allows setting custom domains. It is only allowed if external_http and external_https are set. This MR uncomments these settings so that they are present in the final config that is generated for pages.

Right now, if gdk reconfigure is run, these settings need to be added again every time.

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.
Edited by Vishal Tak

Merge request reports