Adding Settings for Secure Files Object Storage
What does this Merge Request do and why?
This change adds settings configuration to support the Secure Files mechanism discussed in gitlab#346290 (closed).
The feature is designed to support folks who need a simple way to add binary files to their CI pipelines. The use case I'm focused on is in the code signing process for mobile teams, but this approach has been generalized to support other use cases as well.
This first iteration supports basic API interactions. Future iterations will support direct integration with the GitLab Runner, as well as a UI for file uploads and viewing (discussion here).
I recorded a demo of this feature as well: https://youtu.be/eK3FUskHfdo
Merge Request checklist
-
This change is backward compatible. If not, please include steps to communicate to our users. -
Tests added for new functionality. If not, please raise Issue to follow-up. -
Documentation added/updated, if needed. -
gdk doctor
test added, if needed. -
Add the ~highlight
label if this MR should be included in theCHANGELOG.md
.
Merge request reports
Activity
added Category:GDK Engineering Productivity Quality labels
assigned to @darbyfrey
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer ~ Gary Holtz ( @garyh
) (UTC-6)Ash McKenzie ( @ashmckenzie
) (UTC+11)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 Dangerrequested review from @ashmckenzie
changed milestone to %14.8
- Resolved by Ash McKenzie
Thanks for creating @darbyfrey
👍 @seanarnold am adding you as initial reviewer seeing as you spotted this yesterday, may you please review when time permits?
🙏 Edited by Ash McKenzie
requested review from @seanarnold
CI issues are caused by gitlab!78298 (merged).
mentioned in merge request gitlab!78227 (merged)
removed review request for @seanarnold
mentioned in commit 1b499581
mentioned in merge request !2405 (merged)