Skip to content

Makefile: Stop nuking gitlab/tmp/tests/gitaly

Toon Claes requested to merge toon-gitaly-no-clean into main

What does this Merge Request do and why?

A long time ago some users complained [1] Gitaly setup sometimes failed. As a response a workaround was added in 5a173a19 (Remove test gitaly install during 'gdk update', 2017-08-02). While this works great, it increases the setup time op Gitaly in test, and since Gitaly is now also building git(1) and libgit2, this setup time is quite long.

Over the past year a lot of effort is used to make the Makefile used by Gitaly more resilient. So to shorten the setup time again, this change removes the workaround that deletes gitlab/tmp/tests/gitaly.

  1. gitlab-foss#35859 (closed)

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Merge request reports