Skip to content

Allow Rails hostname, port and HTTPS to be configured

Ash McKenzie requested to merge 1147-gitpod-instance-url-is-not-set-correctly into main

What does this Merge Request do and why?

This MR allows the Rails hostname, port and https to be configured which changes how Rails produces URLs. In the specific scenario of Gitpod where they run their own reverse proxy, we need to run services on localhost3:3000 / 127.0.0.1:3000 but also be able to help Rails know the public facing details that Gitpod listens on, e.g. https://lime-bear-lkfl5t1q.ws-us16.gitpod.io but not https://lime-bear-lkfl5t1q.ws-us16.gitpod.io:3000.

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Related

Edited by Ash McKenzie

Merge request reports