Skip to content

Fix gdk psql splitting arguments with spaces

Simon Tomlinson requested to merge fix-psql-quoting into main

What does this Merge Request do and why?

Before this change, gdk psql was splitting arguments to psql that had spaces in them.

For example, gdk psql -d gitlabhq_test -c 'select 1' was passed as psql -c select 1, which psql cannot handle.

Now, gdk psql -d gitlabhq_test -c 'select 1' gets passed equivalently to psql -c 'select 1', so arguments with spaces can be used.

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Merge request reports