Skip to content

Resolve "support/upgrade-postgresql failing with an error"

Ash McKenzie requested to merge 1209-support-upgrade-postgresql-failing-with-an-error into main

What does this Merge Request do and why?

This MR ensures gdk stop is executed correctly as well as gdk reconfigure called once the postgresql/data directory has been upgraded:

$ support/upgrade-postgresql
ℹ️ Available PostgreSQL versions: {11=>"/Users/ash/.asdf/installs/postgres/11.9/bin", 12=>"/Users/ash/.asdf/installs/postgres/12.4/bin"}
ℹ️ Initializing '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data.12.1619145837' for PostgreSQL 12..
ℹ️ Renaming /Users/ash/src/gitlab/gitlab-development-kit/postgresql/data to /Users/ash/src/gitlab/gitlab-development-kit/postgresql/data.11.1619145838
ℹ️ Upgrading '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data.11.1619145838' (PostgreSQL 11) to '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data.12.1619145837' PostgreSQL 12..
ℹ️ Promoting newly-creating database from '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data.12.1619145837' to '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data'
ℹ️ Running 'gdk reconfigure'..
✅️ Upgraded '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data' from PostgreSQL 11 to 12.

$ support/upgrade-postgresql
ℹ️  Available PostgreSQL versions: {11=>"/Users/ash/.asdf/installs/postgres/11.9/bin", 12=>"/Users/ash/.asdf/installs/postgres/12.4/bin"}
✅️ '/Users/ash/src/gitlab/gitlab-development-kit/postgresql/data' is already compatible with PostgreSQL 12.

Merge Request checklist

  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
  • Add the ~highlight label if this MR should be included in the CHANGELOG.md.

Closes #1209 (closed)

Edited by Ash McKenzie

Merge request reports