Standarize CI job names with -'s, not _'s

What does this Merge Request do?

With the recent addition of the danger-review CI job it further muddied the waters of our CI job names with some being separated by - and some with _. Using gitlab-org/gitlab as the canonical source, it became clear that the vast majority of CI job names are separated by -.

This MR updates GDK CI jobs to replace _'s with -'s in their job name where it can be done without breaking things (e.g. we can't rename the code_quality job).

Merge Request checklist

• Tests added for new functionality. If not, please raise Issue to follow-up.
• This change is backward compatible. If not, please include steps to communicate to our users.
• Documentation added/updated, if needed.
• gdk doctor test added, if needed.

Closes #1184 (closed)