Skip to content

Support full SHAs for components

Ash McKenzie requested to merge ashmckenzie/support-full-shas into master

What does this Merge Request do?

This MR allows bin/resolve-dependency-commitish to support versions not only in the format of =1.2.3 and 1.2.3 but also 40 character SHAs which is used at gitlab@f31b1c7b.

Before

$ bin/resolve-dependency-commitish gitlab/GITLAB_SHELL_VERSION
v13.3.0

$ bin/resolve-dependency-commitish gitlab/GITALY_SERVER_VERSION
vd08b7024a0a2882dc55d8a480d891fc0ded5bb9b

Now

$ bin/resolve-dependency-commitish gitlab/GITLAB_SHELL_VERSION
v13.3.0

$ bin/resolve-dependency-commitish gitlab/GITALY_SERVER_VERSION
d08b7024a0a2882dc55d8a480d891fc0ded5bb9b

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
Edited by 🤖 GitLab Bot 🤖

Merge request reports