Allow object_store.host to be defined
What does this Merge Request do?
This MR allows object_store.host
to be defined in gdk.yml
. It now defaults to 127.0.0.1
but can be configured.
Context
When Auto DevOps is configured (auto_devops.enabled = true
in gdk.yml), the minio
(object_store) service that is rendered in Procfile
is incorrect, e.g.
minio: exec env MINIO_REGION=gdk MINIO_ACCESS_KEY=minio MINIO_SECRET_KEY=gdk-minio minio server -C minio/config --address "23013.qa-tunnel.gitlab.info:9000" --compat minio/data
minio
complains that it can't listen on 23013.qa-tunnel.gitlab.info:9000
which is understandable
With this MR, the minio
(object_store) service that is rendered in Procfile
by default is now:
minio: exec env MINIO_REGION=gdk MINIO_ACCESS_KEY=minio MINIO_SECRET_KEY=gdk-minio minio server -C minio/config --address "127.0.0.1:9001" --compat minio/data
Merge Request checklist
-
Tests added for new functionality. If not, please raise Issue to follow-up. -
This change is backward compatible. If not, please include steps to communicate to our users. -
Documentation added/updated, if needed. -
gdk doctor
test added, if needed.