Add shellcheck CI job
What does this Merge Request do?
Adds a CI job for ShellCheck, and fixes existing violations.
Merge Request checklist
-
Tests added for new functionality. If not, please raise Issue to follow-up. -
This change is backward compatible. If not, please include steps to communicate to our users. -
Documentation added/updated, if needed. -
gdk doctor
test added, if needed.
Edited by 🤖 GitLab Bot 🤖
Merge request reports
Activity
added groupconfigure [DEPRECATED] label
added 2 commits
- Resolved by Ash McKenzie
mentioned in merge request !1192 (closed)
changed milestone to %13.0
added 6 commits
-
9b46fb89...faaee628 - 2 commits from branch
master
- 86b82dd2 - WIP: Misc code quality fixes
- 18cc7942 - Add shellcheck CI job
- 0c2f47e2 - Fix shellcheck violations
- abbeda99 - Use new support/ci/shellcheck helper
Toggle commit list-
9b46fb89...faaee628 - 2 commits from branch
added 2 commits
- Resolved by Toon Claes
Hey @toon
can you please review? Thanks!- Resolved by Toon Claes
- Resolved by Toon Claes
- Resolved by Ash McKenzie
- Resolved by Toon Claes
- Resolved by Toon Claes
- Resolved by Ash McKenzie
- Resolved by Ash McKenzie
@tigerwnz This is awesome, I didn't realize
shellcheck
was this thorough, great addition. Back to you.assigned to @ashmckenzie
marked as a Work In Progress from 4e41d99f
- Resolved by Ash McKenzie
- Resolved by Ash McKenzie
Another look please @toon
assigned to @toon and unassigned @ashmckenzie
assigned to @ashmckenzie and unassigned @toon
marked as a Work In Progress from c82b03c2
assigned to @toon
Please register or sign in to reply