Skip to content
Snippets Groups Projects

Add shellcheck CI job

Merged Tiger Watson requested to merge tw/misc-code-quality-fixes into master

What does this Merge Request do?

Adds a CI job for ShellCheck, and fixes existing violations.

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ash McKenzie mentioned in merge request !1192 (closed)

    mentioned in merge request !1192 (closed)

  • Ash McKenzie added 1 commit

    added 1 commit

    • 6608fc3d - Use new support/ci/shellcheck helper

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • 12dff4ab - Use new support/ci/shellcheck helper

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • 9b46fb89 - Use new support/ci/shellcheck helper

    Compare with previous version

  • Tiger Watson changed milestone to %13.0

    changed milestone to %13.0

  • Tiger Watson changed title from WIP: Misc code quality fixes to WIP: Add shellcheck CI job

    changed title from WIP: Misc code quality fixes to WIP: Add shellcheck CI job

  • Tiger Watson changed the description

    changed the description

  • Ash McKenzie added 6 commits

    added 6 commits

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • a0950200 - WIP: Debugging shellcheck CI job

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • b23f2a5c - WIP: Debugging shellcheck CI job

    Compare with previous version

  • Ash McKenzie added 1 commit

    added 1 commit

    • 7e8fbc6a - Use new support/ci/shellcheck helper

    Compare with previous version

  • Tiger Watson added 1 commit

    added 1 commit

    • ee0676e3 - Test introducing a shellcheck violation

    Compare with previous version

  • Ash McKenzie added 2 commits

    added 2 commits

    • fa09e7be - Use new support/ci/shellcheck helper
    • defb0cba - Test introducing a shellcheck violation

    Compare with previous version

  • Tiger Watson unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Tiger Watson changed the description

    changed the description

  • Tiger Watson
  • Author Maintainer

    Hey @toon :wave: can you please review? Thanks!

  • Tiger Watson assigned to @toon and unassigned @tigerwnz

    assigned to @toon and unassigned @tigerwnz

  • Ash McKenzie marked the checklist item This change is backward compatible. If not, please include steps to communicate to our users. as completed

    marked the checklist item This change is backward compatible. If not, please include steps to communicate to our users. as completed

  • Toon Claes resolved all threads

    resolved all threads

  • Toon Claes
  • Toon Claes
  • Toon Claes
  • Toon Claes
  • Toon Claes
  • Toon Claes
  • Toon Claes
  • @tigerwnz This is awesome, I didn't realize shellcheck was this thorough, great addition. Back to you.

  • Toon Claes assigned to @tigerwnz and unassigned @toon

    assigned to @tigerwnz and unassigned @toon

  • Ash McKenzie added 12 commits

    added 12 commits

    Compare with previous version

  • Ash McKenzie marked as a Work In Progress from 4e41d99f

    marked as a Work In Progress from 4e41d99f

  • Ash McKenzie unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ash McKenzie added 1 commit

    added 1 commit

    • e566780e - shellcheck source and exclusion fixes

    Compare with previous version

  • Ash McKenzie assigned to @toon and unassigned @ashmckenzie

    assigned to @toon and unassigned @ashmckenzie

  • Toon Claes assigned to @ashmckenzie and unassigned @toon

    assigned to @ashmckenzie and unassigned @toon

  • Ash McKenzie added 7 commits

    added 7 commits

    Compare with previous version

  • Ash McKenzie marked as a Work In Progress from c82b03c2

    marked as a Work In Progress from c82b03c2

  • assigned to @toon

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading