Skip to content

Ensure geo.enabled is set to true when running make geo-setup

Ash McKenzie requested to merge 805-investigate-why-gitlab-config-database_geo-yml-is-being-created-for-some-people into master

What does this Merge Request do?

This MR ensures geo.enabled is set to true when running make geo-setup by adding a new Makefile target called geo-setup-check that is called first time as part of running make geo-setup.

$ make geo-setup
ERROR: geo.enabled is not set in your gdk.yml
exit 1
make: *** [geo-setup-check] Error 1

This MR also adds a new gdk doctor checkup:

$ gdk doctor
--snip--

Geo
--------------------------------------------------------------------------------
/Users/ash/src/gdk/gdk-secondary/gitlab/config/database_geo.yml exists but
geo.enabled is not set to true in your gdk.yml.

Either update your gdk.yml to set geo.enabled to true or remove
/Users/ash/src/gdk/gdk-secondary/gitlab/config/database_geo.yml

https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/howto/geo.md

--snip--

Merge Request checklist

  • Tests added for new functionality. If not, please raise Issue to follow-up.
  • This change is backward compatible. If not, please include steps to communicate to our users.
  • Documentation added/updated, if needed.
  • gdk doctor test added, if needed.

Closes #805 (closed)

Edited by Ash McKenzie

Merge request reports