When using spring, it needs to be stopped before gdk update will work

From @engwan at #679 (comment 314532371)

PG::ObjectInUse: ERROR:  database "gitlabhq_test" is being accessed by other users
DETAIL:  There is 1 other session using the database.
/usr/local/opt/asdf/installs/ruby/2.6.5/bin/bundle:23:in `load'
/usr/local/opt/asdf/installs/ruby/2.6.5/bin/bundle:23:in `<main>'
Tasks: TOP => db:test:load => db:test:purge
(See full trace by running task with --trace)
make: *** [gitlab-update] Error 1

So I have to do bin/spring stop before gdk update

added typebug label

mentioned in issue #679 (closed)

I'm not 100% sure about this because it doesn't happen every time. I don't know if Spring would cause a DB connection to be held open

But as far as I can remember, I just do bin/spring stop when this happens and it fixes it.

@ashmckenzie @engwan not sure how related this is, but I frequently get module tree errors when using Spring with RSpec and making code changes:

Example backtrace

      ArgumentError:
        A copy of Gitlab::SidekiqMiddleware::AdminMode::Client has been removed from the module tree but is still active!
      Shared Example Group: "an issuable" called from ./spec/requests/api/todos_spec.rb:321
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/dependencies.rb:530:in `load_missing_constant'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:61:in `block in load_missing_constant'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:17:in `allow_bootsnap_retry'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:60:in `load_missing_constant'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/dependencies.rb:214:in `const_missing'
      # ./lib/gitlab/sidekiq_middleware/admin_mode/client.rb:11:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # ./lib/gitlab/sidekiq_status/client_middleware.rb:10:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # ./lib/gitlab/sidekiq_middleware/duplicate_jobs/client.rb:9:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/gitlab-labkit-0.12.0/lib/labkit/middleware/sidekiq/client.rb:21:in `block in call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/gitlab-labkit-0.12.0/lib/labkit/middleware/sidekiq/context/client.rb:15:in `block in call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/gitlab-labkit-0.12.0/lib/labkit/context.rb:32:in `with_context'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/gitlab-labkit-0.12.0/lib/labkit/middleware/sidekiq/context/client.rb:12:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in `invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/gitlab-labkit-0.12.0/lib/labkit/middleware/sidekiq/client.rb:20:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # ./lib/gitlab/sidekiq_middleware/worker_context.rb:9:in `wrap_in_optional_context'
      # ./lib/gitlab/sidekiq_middleware/worker_context/client.rb:18:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in `invoke'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/client.rb:212:in `process_single'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/client.rb:71:in `push'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/worker.rb:149:in `client_push'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/worker.rb:108:in `perform_in'
      # ./config/initializers/forbid_sidekiq_in_transactions.rb:36:in `block (2 levels) in <module:NoEnqueueingFromTransactions>'
      # ./app/models/concerns/update_highest_role.rb:29:in `block in update_highest_role'
      # ./lib/after_commit_queue.rb:25:in `instance_eval'
      # ./lib/after_commit_queue.rb:25:in `block in run_after_commit_or_now'
      # ./config/initializers/forbid_sidekiq_in_transactions.rb:8:in `skipping_transaction_check'
      # ./lib/after_commit_queue.rb:24:in `run_after_commit_or_now'
      # ./app/models/concerns/update_highest_role.rb:24:in `update_highest_role'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:429:in `block in make_lambda'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:274:in `block in simple'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:518:in `block in invoke_after'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:518:in `each'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:518:in `invoke_after'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:136:in `run_callbacks'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/callbacks.rb:827:in `_run_commit_callbacks'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/transactions.rb:340:in `committed!'
      # ./config/initializers/forbid_sidekiq_in_transactions.rb:50:in `block in committed!'
      # ./config/initializers/forbid_sidekiq_in_transactions.rb:8:in `skipping_transaction_check'
      # ./config/initializers/forbid_sidekiq_in_transactions.rb:50:in `committed!'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/transaction.rb:127:in `commit_records'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/transaction.rb:265:in `block in commit_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/transaction.rb:255:in `commit_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/transaction.rb:293:in `block in within_new_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/transaction.rb:278:in `within_new_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/connection_adapters/abstract/database_statements.rb:281:in `transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/transactions.rb:212:in `transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/transactions.rb:366:in `with_transaction_returning_status'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/transactions.rb:319:in `save!'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activerecord-6.0.2.2/lib/active_record/suppressor.rb:48:in `save!'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-activerecord-0.6.0/lib/state_machines/integrations/active_record.rb:515:in `block in save!'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-activerecord-0.6.0/lib/state_machines/integrations/active_record.rb:530:in `block in around_save'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:150:in `block in run_actions'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:170:in `catch_exceptions'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:148:in `run_actions'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:133:in `run_callbacks'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:212:in `run_callbacks'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:63:in `block (2 levels) in perform'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:63:in `catch'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:63:in `block in perform'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:186:in `within_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-0.5.0/lib/state_machines/transition_collection.rb:62:in `perform'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-activerecord-0.6.0/lib/state_machines/integrations/active_record.rb:530:in `around_save'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/state_machines-activerecord-0.6.0/lib/state_machines/integrations/active_record.rb:515:in `save!'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/evaluation.rb:18:in `create'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy/create.rb:12:in `block in result'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy/create.rb:9:in `tap'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy/create.rb:9:in `result'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory.rb:43:in `run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory_runner.rb:29:in `block in run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/notifications.rb:182:in `instrument'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory_runner.rb:28:in `run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy_syntax_method_registrar.rb:20:in `block in define_singular_strategy_method'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/evaluator.rb:44:in `method_missing'
      # ./spec/factories/projects.rb:20:in `block (3 levels) in <main>'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute/dynamic.rb:16:in `instance_exec'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute/dynamic.rb:16:in `block in to_proc'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/evaluator.rb:77:in `instance_exec'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/evaluator.rb:77:in `block in define_attribute'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:59:in `get'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:16:in `block (2 levels) in object'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:15:in `each'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:15:in `block in object'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:14:in `tap'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/attribute_assigner.rb:14:in `object'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/evaluation.rb:13:in `object'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy/create.rb:9:in `result'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory.rb:43:in `run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory_runner.rb:29:in `block in run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/notifications.rb:182:in `instrument'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/factory_runner.rb:28:in `run'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/factory_bot-5.1.0/lib/factory_bot/strategy_syntax_method_registrar.rb:20:in `block in define_singular_strategy_method'
      # ./spec/requests/api/todos_spec.rb:7:in `block (2 levels) in <main>'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/recipes/rspec/let_it_be.rb:96:in `instance_exec'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/recipes/rspec/let_it_be.rb:96:in `block in let_it_be'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/recipes/rspec/before_all.rb:30:in `instance_eval'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/recipes/rspec/before_all.rb:30:in `block (2 levels) in within_before_all'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/before_all.rb:28:in `within_transaction'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/test-prof-0.10.0/lib/test_prof/recipes/rspec/before_all.rb:29:in `block in within_before_all'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:55:in `load'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:55:in `load'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/dependencies.rb:319:in `block in load'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/dependencies.rb:291:in `load_dependency'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/activesupport-6.0.2.2/lib/active_support/dependencies.rb:319:in `load'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/spring-commands-rspec-1.0.4/lib/spring/commands/rspec.rb:18:in `call'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork'
      # /etc/dotfiles/rbenv/gems/2.6.0/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork'
      # -e:1:in `<main>'

It seems to always happen with Gitlab::SidekiqMiddleware::AdminMode::Client so far. The error goes away after 2-3 attempts (re-running spring rspec without restarting Spring).

Before Rails 6 / Zeitwerk I think I sometimes got these errors too, but not nearly as often.

Yeah, I get that very often too that I just disabled Spring for now.

This is related to code-reloading. We're actually not on Zeitwerk yet. It was reverted.

This is because we shouldn't be holding references to autoloaded classes inside of non-autoloaded classes like those in gems like Sidekiq.

As the code reloader unloads the autoloaded classes, these become stale references hence the error.

I started getting this same error recently. It wasn't happening to me before.

Backtrace

     ArgumentError:
       A copy of Gitlab::SidekiqMiddleware::AdminMode::Client has been removed from the module tree but is still active!
     # ./lib/gitlab/sidekiq_middleware/admin_mode/client.rb:11:in `call'
     # ./lib/gitlab/sidekiq_status/client_middleware.rb:10:in `call'
     # ./lib/gitlab/sidekiq_middleware/duplicate_jobs/client.rb:9:in `call'
     # ./lib/gitlab/sidekiq_middleware/worker_context.rb:9:in `wrap_in_optional_context'
     # ./lib/gitlab/sidekiq_middleware/worker_context/client.rb:18:in `call'
     # ./config/initializers/forbid_sidekiq_in_transactions.rb:36:in `block (2 levels) in '
     # ./app/models/concerns/update_highest_role.rb:29:in `block in update_highest_role'
     # ./lib/after_commit_queue.rb:25:in `instance_eval'
     # ./lib/after_commit_queue.rb:25:in `block in run_after_commit_or_now'
     # ./config/initializers/forbid_sidekiq_in_transactions.rb:8:in `skipping_transaction_check'
     # ./lib/after_commit_queue.rb:24:in `run_after_commit_or_now'
     # ./app/models/concerns/update_highest_role.rb:24:in `update_highest_role'
     # ./config/initializers/forbid_sidekiq_in_transactions.rb:50:in `block in committed!'
     # ./config/initializers/forbid_sidekiq_in_transactions.rb:8:in `skipping_transaction_check'
     # ./config/initializers/forbid_sidekiq_in_transactions.rb:50:in `committed!'
     # ./ee/spec/controllers/projects/feature_flags_controller_spec.rb:9:in `block (2 levels) in '
     # -e:1:in `'

I'm not sure I follow, @engwan, is there something that changed recently that would cause this?

I'm not sure what changed to make this happen more frequently.

But the way we're doing autoloading isn't supposed to work very well. We're keeping a reference to a reloadable class (Gitlab::SidekiqMiddleware::AdminMode::Client) in a non-reloadable class (Sidekiq's middleware chain).

https://stackoverflow.com/a/29710188 has more details.

I see that this was added fairly recently gitlab@96a9f3d3, maybe that's why.

The stacktrace also points to the line where it calls: Feature.enabled? so I think it's because it is trying to autoload the Feature class. Changing it to ::Feature might help. And also ::Gitlab::AppLogger, etc..

The explanation for this is in the SO answer. The exception happens when Gitlab::SidekiqMiddleware::AdminMode::Client.const_missing is invoked and that class was already unloaded. Changing it to :: makes it so that Object.const_missing is used to autoload.

Thanks for reporting these by the way. I think I have a better understanding of the problem now and this is related to gitlab#211875 (closed).

I'll update the issue to make it more generic since it's also a problem pre-Zeitwerk.

mentioned in merge request gitlab!31512 (merged)

@jagood are you happy to close this Issue or to move it into gitlab-org/gitlab given it looks more like a GitLab Rails issue?

@ashmckenzie I don't think I've ever run into the issue in the original description. I think the comments here between @engwan and myself might have been something else? I think we resolved that with gitlab!31512 (merged), so that much is cleared up.

I'm fine with closing this, but I may not be the person to ask.

Well, I just got this for the first time. Maybe I've just never noticed before?

I did a gdk udpate again and it didn't happen the second time. I did not stop spring first.

Yeah, I don't get this every time. I think it happens when a test is ran recently.

After a while, I guess the DB connection is disconnected due to idle timeout so we don't see this problem.

I've started to see this pop up when running gdk update (even after letting my laptop sit overnight) and the only way I can get it to stop is to run gdk stop. FWIW, I tried stopping spring and that didn't help.

Next time it happens, I'll see if I can gather some more information.

I get this quite often but spring stop always works. As @engwan suggested in Slack, maybe gdk update should just run spring stop?

This happens so often on my workflow, that I have an alias like this and I never call gdk stop

alias gdkstop='gdk stop && bin/spring stop'

While not solving the root cause, !1620 (merged) may be of interest here.

In a follow-up MR, I'll add before/after hook support for gdk update that includes spring stop as a default before hook

added Category:GDK devopscreate groupecosystem [DEPRECATED] labels

added sectiondev label

mentioned in merge request !1620 (merged)

@dlouzan @engwan @smcgivern Now !1620 (merged) is merged you can add this to gdk.yml:

gdk:
  update_hooks:
    before:
      - cd gitlab && bin/spring stop

Please give it a try and let us now if it works for you. If it does we maybe can make this built-in in some way, or at least properly document it.

@toon nice, I will try that! I can also do git checkout -- db/structure.sql post-update

$ gdk update
ℹ️  gdk update: before hook -> cd gitlab && bin/spring stop
Spring is not running

I can also do git checkout -- db/structure.sql post-update

cough git -C gitlab checkout -- db/structure.sql cough

Oh nice, I just did cd gitlab && again.

@toon Been running this over the last days, it's a thing of beauty

In my case I've also added the spring stop to stop_hooks, since in the typical case I stop gdk when switching branches for different upstream MRs.

Great to hear @dlouzan, I'll add cd gitlab && bin/spring stop to both stop/update pre before hooks by default

Edit: !1708 (merged)

assigned to @ashmckenzie

changed milestone to %13.7

mentioned in merge request !1708 (merged)

closed with merge request !1708 (merged)

mentioned in commit fdaea1eb

added 1 deleted label and removed devopscreate label

I've seen this error during my last couple make geo-primary-updates. It looks like this command doesn't execute the gdk update hooks?

Maybe or maybe not interesting notes: During today's occurrence, I was able to get the error at least 3 times (though it changed from erroring on gitlab_geo_development to gitlab_test) even though my alias restarts the DBs (I was under the impression that that fixed the problem for me in the past). Adding bin/spring stop to my alias resolved it.

I'm not opening another issue for the geo commands since they are not used by many people, adding bin/spring to an alias is easy, and it doesn't sound like it would be trivial to add to the geo make commands. Mostly I'm commenting here for the few who may search for the error in this project's issues.

Hmm... I just saw the error on gitlabhq_geo_development again

added devopsmanage label and removed 1 deleted label