gdk update can fail to update if gitlab is on a branch
This happened today to @clenneville:
- The
gitlab
directory was on an old branch (last commit was in March 2019). - When
gdk update
runs, it attempts to update Gitaly based on thegitlab/GITALY_SERVER_VERSION
. In her case, it was v1.29.0. -
gdk update
checked out Gitaly v1.29.0, but thebundle install
failed because the gRPC version was outdated for Ruby 2.6.
To fix this, I think gdk update
should run the git checkout master
on the gitlab
directory first before attempting to read the respective versions.