Skip to content
Snippets Groups Projects

Fixed label select toggle not updating correctly

Merged Phil Hughes requested to merge label-select-toggle into master
1 unresolved thread

What does this MR do?

Fixes the label select toggle label not correctly updating after selecting/de-selecting labels in the dropdown.

Screenshots (if relevant)

label-update

What are the relevant issue numbers?

Closes #26119 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
71
72 it 'correctly updates the dropdown toggle when removing a label' do
73 click_button 'Labels'
74
75 page.within '.dropdown-menu-labels' do
76 click_link label.title
77 end
78
79 expect(find('.js-label-select')).to have_content(label.title)
80
81 page.within '.dropdown-menu-labels' do
82 click_link label.title
83 end
84
85 expect(find('.js-label-select')).to have_content('Labels')
86 end
  • Fatih Acet added ~149423 label

    added ~149423 label

  • @rymai I added ~"Pick into Stable" to this one because I was assuming issue has regression label. It doesn't have regression but reproduced on GitLab.com. Now I realised this after checking the original issue once again. However I think this still should be ~"Pick into Stable". Can you please review and remove label if you don't agree? Sorry for bothering you with this.

  • @fatihacet Makes sense, thanks!

  • mentioned in issue #27400 (closed)

  • Picked into 8-16-stable, will be in 8.16.3

  • Robert Speicher removed ~149423 label

    removed ~149423 label

  • Please register or sign in to reply
    Loading