Skip to content

Ensure updating project settings shows a flash message on success

Rémy Coutable requested to merge sandish/gitlab-ce-update_ret_val into master

EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1060

Originally opened at !2994 (closed) by @sandish.

Issue: when changed project settings and submit, the notice("Project '#{@project.name}' was successfully updated.") was not displayed.

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/projects_controller.rb#L46

def update
    status = ::Projects::UpdateService.new(@project, current_user, project_params).execute

    respond_to do |format|
      if status
        flash[:notice] = "Project '#{@project.name}' was successfully updated."
        format.html do
          redirect_to(
            edit_project_path(@project),
            notice: "Project '#{@project.name}' was successfully updated."
          )
        end
        format.js
      else
        format.html { render 'edit' }
        format.js
      end
    end
  end

Version: 8.5(latest release)

So I add a return value for the project update service to fix the issue.

Merge request reports