Ensure issuable state changes only fire webhooks once
What does this MR do?
Ensure issuable state changes only fire webhooks once
Are there points in the code the reviewer needs to double check?
Check to see if the tests could be refactored, possibly into a shared context as they are very similar?
Why was this MR needed?
Webhooks were fired twice when issuables were reopened or closed. Once for the status change and once for the update
operation
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #25339 (closed)
Merge request reports
Activity
@markglenfletcher Awesome work, thank you!
changed milestone to %8.14
Check to see if the tests could be refactored, possibly into a shared context as they are very similar?
@markglenfletcher Yeah, makes sense to create a new
spec/support/services/issuable_update_service_shared_examples.rb
!assigned to @markglenfletcher
mentioned in issue #24354 (closed)
added 1 commit
- 3a73a7c2 - Ensure issuable state changes only fire webhooks once
added 1 commit
- 9f97fa4d - Ensure issuable state changes only fire webhooks once
@rymai I refactored the tests that I've added to use a shared example. I think a lot of the other tests are also duplicated, but I'd like to look into refactoring these in another MR. Does that sounds OK?
assigned to @rymai
@markglenfletcher Sounds good, thanks!
changed milestone to %8.15
mentioned in commit 02ecc222
mentioned in issue #25721 (closed)
mentioned in commit c7ba87ca
I have set the 8.14 milestone, because it's already picked into
8.15
.Edited by Douglas Barbosa Alexandrechanged milestone to %8.14
mentioned in issue #21193 (closed)
mentioned in commit 5797c80a
mentioned in issue #27130 (closed)
added Category:Webhooks label and removed 1 deleted label