Skip to content
Snippets Groups Projects

Feature to create directly addressed Todos when mentioned in beginning

All threads resolved!

What does this MR do?

Adds a feature to create a 'directly addressed' Todo when @user (or multiple users) are mentioned in the beginning of a note.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2016-12-06_at_3.18.56_am

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #24976 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @ershadk thanks! Please add any outstanding items to a comment or the description.

    @DouweM would you like to take a look too?

  • assigned to @DouweM

  • added 2 commits

    • 57764199 - fix gfm doc typo about two spaces for next line transfer
    • 8d00e72d - Create directly_addressed Todos when mentioned in beginning

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • @smcgivern I did, and I have no feedback beyond what you've already pointed out :)

  • Ershad Kunnakkadan added 206 commits

    added 206 commits

    • fd9d9e55...05efd19e - 204 commits from branch gitlab-org:master
    • 34739997 - Create directly_addressed Todos when mentioned in beginning
    • ec55d977 - Upgrading TargetRubyVersion for rubocop

    Compare with previous version

  • assigned to @smcgivern

  • added 2 commits

    • caf451c0 - Create directly_addressed Todos when mentioned in beginning
    • d9deaddc - Upgrading TargetRubyVersion for rubocop

    Compare with previous version

  • added 2 commits

    • e263b099 - Create directly_addressed Todos when mentioned in beginning
    • 85058ae1 - Upgrading TargetRubyVersion for rubocop

    Compare with previous version

  • Author Contributor

    Thank you, @DouweM!

    @smcgivern updated the MR, please have a look :slight_smile:

  • added 1 commit

    Compare with previous version

  • marked the task Squashed related commits together as incomplete

  • @ershadk thanks, I'd love to fix this so that we only pick up the really directly mentioned users, if that's possible!

  • assigned to @ershadk

  • added 1 commit

    • 3fccc0f3 - Create directly_addressed Todos when mentioned in beginning

    Compare with previous version

  • Ershad Kunnakkadan added 131 commits

    added 131 commits

    • 3fccc0f3...d8d07976 - 130 commits from branch gitlab-org:master
    • 1ec28c4b - Create directly_addressed Todos when mentioned in beginning

    Compare with previous version

  • added 1 commit

    • 02187dd8 - Create directly_addressed Todos when mentioned in beginning

    Compare with previous version

  • Author Contributor

    @smcgivern thank you! I've made the changes according to the feedback, please review :slight_smile:

  • Sean McGivern
  • added 1 commit

    • b9356845 - Create directly_addressed Todos when mentioned in beginning

    Compare with previous version

  • Author Contributor

    @smcgivern added comments and updated the MR, please review :slight_smile:

  • @ershadk sorry it took me so long to get to this! I've got a couple of questions above, but I think we're getting there :slight_smile:

  • assigned to @ershadk

  • Author Contributor

    @smcgivern thanks for the feedback! I will make the changes and will let you know :slight_smile:

  • added 1 commit

    • 5650ee48 - Refactored the way how it fetches directly addressed users

    Compare with previous version

  • added 1 commit

    • 5a38b9a2 - Scan for root p nodes while fetching directly addressed users

    Compare with previous version

  • Ershad Kunnakkadan added 1369 commits

    added 1369 commits

    • 5a38b9a2...aec04a47 - 1366 commits from branch gitlab-org:master
    • e671469f - Create directly_addressed Todos when mentioned in beginning
    • 3dc0e579 - Refactored the way how it fetches directly addressed users
    • 3dee4c9b - Scan for root p nodes while fetching directly addressed users

    Compare with previous version

  • added 1 commit

    • dd29562d - Scan for root p nodes while fetching directly addressed users

    Compare with previous version

  • added 1 commit

    • b5205f4d - Scan for root p nodes while fetching directly addressed users

    Compare with previous version

  • Author Contributor

    @smcgivern updated the MR, please have a look :slight_smile:

  • Sean McGivern
  • Sean McGivern
  • @ershadk thanks, this is definitely close to being ready! I have some minor nitpicks in the specs, and then I'd just like lib/banzai/querying.rb to be a little clearer, and then I think we're good. Awesome work! :tada:

  • Rémy Coutable added ~480950 ~157967 labels

    added ~480950 ~157967 labels

  • added 1 commit

    • 4f5a9700 - Create directly_addressed Todos when mentioned in beginning of a line

    Compare with previous version

  • Author Contributor

    @smcgivern thank you very much for the feedback! Updated the MR, please review :slight_smile:

  • Ershad Kunnakkadan marked the task Added for this feature/bug as completed

    marked the task Added for this feature/bug as completed

  • Ershad Kunnakkadan marked the task All builds are passing as completed

    marked the task All builds are passing as completed

  • Ershad Kunnakkadan marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • marked the task Squashed related commits together as incomplete

  • Sean McGivern resolved all discussions

    resolved all discussions

  • @ershadk thanks, I assume this isn't WIP any more? :wink:

    I tried this locally and it looks pretty good to me :thumbsup:

  • Ershad Kunnakkadan unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Author Contributor

    @smcgivern yay! thank you! Removed WIP from title :slight_smile:

  • @ershadk can you fix the conflicts, please? :boom:

  • Sean McGivern changed milestone to %9.0

    changed milestone to %9.0

  • Ershad Kunnakkadan added 930 commits

    added 930 commits

    • 4f5a9700...11d33873 - 929 commits from branch gitlab-org:master
    • 3a23639b - Create directly_addressed Todos when mentioned in beginning of a line

    Compare with previous version

  • Author Contributor

    @smcgivern fixed the conflicts :slight_smile:

  • merged

  • mentioned in issue #31978 (closed)

  • Jarka Košanová mentioned in merge request !11243 (merged)

    mentioned in merge request !11243 (merged)

  • mentioned in issue gitlab#513937

  • GitLab Community Contributions Toolbox Bot changed the description

    changed the description

  • Please register or sign in to reply
    Loading