Feature to create directly addressed Todos when mentioned in beginning
What does this MR do?
Adds a feature to create a 'directly addressed' Todo when @user
(or multiple users) are mentioned in the beginning of a note.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #24976 (closed)
Merge request reports
Activity
Thanks @ershadk! Please let me know when this is ready to review!
assigned to @ershadk
added 1 commit
- f0c97094 - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- 23a73d7f - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- 74b77373 - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- 465ed2ca - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- cc9076fa - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- f2265857 - Create directly_addressed Todos when mentioned in beginning
marked the task Changelog entry added as completed
added 1 commit
- c9adb20d - Create directly_addressed Todos when mentioned in beginning
marked the task Squashed related commits together as completed
added 1 commit
- 20065e5f - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- e7511d95 - Create directly_addressed Todos when mentioned in beginning
added 1 commit
- 5bec972f - Create directly_addressed Todos when mentioned in beginning
added 2 commits
added 1 commit
- 8443c72b - Create directly_addressed Todos when mentioned in beginning
marked the task Squashed related commits together as incomplete
marked the task Squashed related commits together as completed
marked the task Squashed related commits together as incomplete
marked the task Changelog entry added as incomplete
marked the task Changelog entry added as completed
Thanks @ershadk! I will take a look tomorrow.
assigned to @smcgivern
added 1 commit
- 825f0bc5 - Create directly_addressed Todos when mentioned in beginning
marked the task Squashed related commits together as completed
Sure @smcgivern. Thanks!
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
assigned to @DouweM
added 3 commits
-
8d00e72d...89c7db6a - 2 commits from branch
gitlab-org:master
- fd9d9e55 - Create directly_addressed Todos when mentioned in beginning
-
8d00e72d...89c7db6a - 2 commits from branch
@smcgivern I did, and I have no feedback beyond what you've already pointed out :)
added 206 commits
-
fd9d9e55...05efd19e - 204 commits from branch
gitlab-org:master
- 34739997 - Create directly_addressed Todos when mentioned in beginning
- ec55d977 - Upgrading TargetRubyVersion for rubocop
-
fd9d9e55...05efd19e - 204 commits from branch
assigned to @smcgivern
- Resolved by Sean McGivern
Thank you, @DouweM!
@smcgivern updated the MR, please have a look
marked the task Squashed related commits together as incomplete
- Resolved by Sean McGivern
- Resolved by Sean McGivern
@ershadk thanks, I'd love to fix this so that we only pick up the really directly mentioned users, if that's possible!
assigned to @ershadk
added 1 commit
- 3fccc0f3 - Create directly_addressed Todos when mentioned in beginning
added 131 commits
-
3fccc0f3...d8d07976 - 130 commits from branch
gitlab-org:master
- 1ec28c4b - Create directly_addressed Todos when mentioned in beginning
-
3fccc0f3...d8d07976 - 130 commits from branch
added 1 commit
- 02187dd8 - Create directly_addressed Todos when mentioned in beginning
@smcgivern thank you! I've made the changes according to the feedback, please review
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
added 1 commit
- b9356845 - Create directly_addressed Todos when mentioned in beginning
@smcgivern added comments and updated the MR, please review
assigned to @smcgivern
@ershadk sorry it took me so long to get to this! I've got a couple of questions above, but I think we're getting there
assigned to @ershadk
@smcgivern thanks for the feedback! I will make the changes and will let you know
added 1 commit
- 5650ee48 - Refactored the way how it fetches directly addressed users
added 1 commit
- 5a38b9a2 - Scan for root p nodes while fetching directly addressed users
added 1369 commits
-
5a38b9a2...aec04a47 - 1366 commits from branch
gitlab-org:master
- e671469f - Create directly_addressed Todos when mentioned in beginning
- 3dc0e579 - Refactored the way how it fetches directly addressed users
- 3dee4c9b - Scan for root p nodes while fetching directly addressed users
Toggle commit list-
5a38b9a2...aec04a47 - 1366 commits from branch
added 1 commit
- dd29562d - Scan for root p nodes while fetching directly addressed users
added 1 commit
- b5205f4d - Scan for root p nodes while fetching directly addressed users
@smcgivern updated the MR, please have a look
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
@ershadk thanks, this is definitely close to being ready! I have some minor nitpicks in the specs, and then I'd just like
lib/banzai/querying.rb
to be a little clearer, and then I think we're good. Awesome work!added 1 commit
- 4f5a9700 - Create directly_addressed Todos when mentioned in beginning of a line
@smcgivern thank you very much for the feedback! Updated the MR, please review
marked the task Squashed related commits together as completed
marked the task Squashed related commits together as incomplete
marked the task Squashed related commits together as completed
@ershadk thanks, I assume this isn't WIP any more?
I tried this locally and it looks pretty good to me
@smcgivern yay! thank you! Removed
WIP
from title@ershadk can you fix the conflicts, please?
changed milestone to %9.0
added 930 commits
-
4f5a9700...11d33873 - 929 commits from branch
gitlab-org:master
- 3a23639b - Create directly_addressed Todos when mentioned in beginning of a line
-
4f5a9700...11d33873 - 929 commits from branch
@smcgivern fixed the conflicts
Thanks @ershadk!
mentioned in issue #31978 (closed)
mentioned in merge request !11243 (merged)
mentioned in issue gitlab#513937
added linked-issue label
added devopsplan typefeature labels
added devopsfoundations grouppersonal productivity sectioncore platform labels and removed devopsplan label