Speed up Project security access specs

Prior, every single test was creating four ProjectMember objects, each of which created one User record, even though each test only used one of those Users, if any.

Now each test only creates the single user record it needs, if it needs one. This shaves minutes off of each spec file changed here.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

@rspeicher Awesome, simply love it!!

Reassigned to @rspeicher

Added 1 commit:

• 13ad9a74 - Speed up Project security access specs

Compare with previous version

Resolved all discussions

@rymai Thanks! Should be all set.

Reassigned to @rymai

@rspeicher Thanks, LGTM! Please also open a EE MR! ;)

Enabled an automatic merge when the build for 13ad9a74 succeeds

@rymai Done in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/919. Strangely it didn't conflict for me locally.

Status changed to merged

Mentioned in commit 6ea0b8d5

Another nice find!

Mentioned in merge request !7813 (merged)

Mentioned in commit 2e034dbe

mentioned in merge request !7890 (merged)

mentioned in commit 09b35c53

mentioned in commit 141593fa

mentioned in issue #24899 (closed)