Actually support storing backups on Azure
What does this MR do?
This MR replaces the fog-azure
gem with the fog-azure-rm
gem to actually support storing backups on Azure.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
fog-azure
was added by !4444 (merged) to support storing backups on Azure.
Sadly, fog-azure
does only support Compute resources. (see https://github.com/fog/fog-azure/blob/master/lib/fog/bin/azure.rb#L26-L30, http://stackoverflow.com/a/32050560)
As a result, storing backups on Azure is still not possible.
fog-azure-rm
does actually include support for Storage resources.
The gem dependency issue that has caused fog-azure
to be included instead of fog-azure-rm
in the first place has been resolved.
What are the relevant issue numbers?
#1819 (closed) #15352 (closed)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
Thanks @benalbrecht! Could you please rebase?
Looking at the diff, I'm worried at the new dependencies we're introducing here... What do you think @stanhu?
Any updates on being able to get this in? Adding the
fog-azure-rm
dependency would allow GitLab to support backup to Azure which is not currently supported.I'm not sure that
fog-azure
andfog-azure-rm
actually conflict as they have different provider names in fog (Azure
vsAzureRM
). It may be wise not to remove the old dependency.@rspeicher What do you think about my concerns about the new dependencies added here?
@rymai We had similar concerns in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6713 to add Google Cloud backups to fog, which was ultimately closed. I don't think we want the additional dependencies.
I rebased, but the new commits don't seem to show up here.
Edited by Benjamin AlbrechtAdded 7972 commits:
-
190735c1...76ff9fff - 7971 commits from branch
gitlab-org:master
- 042467a2 - Replace fog-azure gem with fog-azure-rm
-
190735c1...76ff9fff - 7971 commits from branch
@rspeicher @stanhu It looks like we initially planned to support Azure (https://gitlab.com/gitlab-org/gitlab-ce/issues/15352#note_11972549), but we had a dependency issue so we used
fog-azure
(https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4396#note_12186687) –which doesn't actually support storage–, but it was not actually added at this time, only a few days later (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4444#note_12330862).@connorshea @stanhu What do you think about:
- the need for supporting Azure backups
- the new gems introduced (please remember that we planned to add them in !4396 (merged) initially)
I think it's legitimate to replace
fog-azure
withfog-azure-rm
but if it's blocking the update to Rails 5, we should reconsider it.Also, if we decide to close this MR, we should also remove the
fog-azure
gem since it's currently useless!Ok, thanks @stanhu! I will take care of removing the gems and updating the documentation.
Sorry @benalbrecht, we'll not accept this merge request, but you can still contribute by documenting how you'd implement upload to Azure yourself...
Thanks again for caring @benalbrecht!
Mentioned in commit 2749c1b5
Mentioned in merge request !7739 (merged)
Mentioned in commit e2f66373
mentioned in issue #55624 (moved)
@benalbrecht Did you ever document a method for getting GitLab backups into Azure?