Skip to content

Add permission check to metrics dashboards

Sarah Yasonik requested to merge add-metrics-dashboard-permission-check into master

What does this MR do?

Adds a permission check to the EnvironmentsController#metrics_dashboard endpoint, preventing anyone without reporter access from retrieving content. Users aren't able to view project > Operations > Metrics without reporter access, but the endpoint should be responsible for managing its own permissions regardless.

This need becomes a little more apparent with including the url in GFM: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29861, though not directly required.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports