Gitlab::JsonCache#parse_value ensure string
What does this MR do?
This MR ensures raw
in Gitlab::JsonCache#parse_value
is always dealing with a string before attempting to call ActiveSupport::JSON.decode
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry [ ] Documentation created/updated or follow-up review issue created-
Code review guidelines -
Merge request performance guidelines -
Style guides [ ] Database guides[ ] Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #63510 (closed)
Merge request reports
Activity
changed milestone to %12.1
added priority1 typebug workflowin dev + 1 deleted label
added backstage [DEPRECATED] label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Imre Farkas ( @ifarkas
)Douwe Maan ( @DouweM
)Generated by
Dangerenabled an automatic merge when the pipeline for 03220c00 succeeds
- Resolved by Ash McKenzie
Looks good to me! The root cause, however, was that we changed the type of data stored in the Rails cache from 11.6 to 11.7. What's more concerning was that 11.6 would read/write serialized ActiveRecord objects, while 11.7 would expect JSON strings. I think this might actually break 11.6, so that's why I'm wondering if we need to be including some version number with this cache key.
mentioned in issue #63513 (closed)
mentioned in commit 78869030
added Pick into auto-deploy label
removed Pick into auto-deploy label
mentioned in commit 7858a176
mentioned in issue gitlab-org/release/tasks#823 (closed)
mentioned in issue gitlab-org/release/tasks#824 (closed)
mentioned in issue gitlab-org/release/tasks#827 (closed)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30045, will merge into
12-0-stable
ready for12.0.2
.mentioned in commit 394a39f8
mentioned in merge request !30045 (merged)
mentioned in issue gitlab-org/release/tasks#831 (closed)
mentioned in issue gitlab-org/release/tasks#834 (closed)
Setting ~"devops::enablement" groupgeo based on ~"Geo".
added devopssystems groupgeo labels
Setting ~"devops::enablement" groupgeo based on ~"Geo".