Skip to content

Add certificate valid time to pages domain table

Vladimir Shushlin requested to merge pages-domain_ssl-valid-period into master

What does this MR do?

It's part of https://gitlab.com/gitlab-org/gitlab-ce/issues/28996

In order to efficiently get domains which need certificate renewal, we need to store validity time in database

We currently have about 15000 domains which would be updated by this migration: https://gitlab.slack.com/archives/CB2S7NNDP/p1558687260002300 So it can be a subject of concern from performance perspective.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports