Skip to content

Add collapsible sections to job log

Kamil Trzciński requested to merge generate-spans-for-sections into master

What does this MR do?

Screen_Recording_2019-06-12_at_16.28.05

Additional approach to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25178

This generates the following (idea) <span> and <div> that should be freely parsed by frontend: image

This follows the proposal outlined here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25178#note_143701979

Consider that data-section contains a space delimited list of all sections in which this element is in. The section names are not sanitised, and can lead to XSS with that implementation. We should normalize section names to safe strings.

Generate a flat list of all sections with markers where they are in trace, and in what sections. This should allow frontend to generate sections and allow to collapse them hooking to section-end markers.

Edited by Filipa Lacerda

Merge request reports