Skip to content

Eager-load image blob data in diffs

Rémy Coutable requested to merge fix/13458-eager-load-blob-data into master

Since gitlab_git 8.0, blob data are lazy-loaded so we have to call blob.load_all_data!(repo) to eager-load them.

Fixes #13458 (closed).

/cc @jacobvosmaer @dblessing @rspeicher

New image in commit view

Before

Screen_Shot_2016-02-16_at_11.28.18

After

Screen_Shot_2016-02-16_at_11.30.56

Replaced image in commit view

Before

Screen_Shot_2016-02-16_at_11.28.20

After

Screen_Shot_2016-02-16_at_11.30.59

Deleted image in commit view

Before

Screen_Shot_2016-02-16_at_11.28.22

After

Screen_Shot_2016-02-16_at_11.31.01

Image diff in merge request diff view

Before

Screen_Shot_2016-02-16_at_11.28.37

After

Screen_Shot_2016-02-16_at_11.31.04

Merge request reports