Skip to content

Cleans up todos.scss style-lint warnings

Filipa Lacerda requested to merge 59930-todos-scss into master

What does this MR do?

Cleans up todos.scss style-lint warnings

There is one warning missing:

app/assets/stylesheets/pages/todos.scss
 198:5  ⚠  ".filter-categories" and ".dropdown-menu-toggle-sort (/Users/filipalacerda/Documents/git/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/todos.scss -155:5)" have the same         stylelint-gitlab/duplicate-selectors
           properties.

It's from a media query, I'm unsure how to fix this one

before after
Screenshot_2019-05-03_at_15.39.48 Screenshot_2019-05-03_at_16.38.44
Screenshot_2019-05-03_at_15.39.27 Screenshot_2019-05-03_at_16.38.30

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #59930 (closed)

Merge request reports