Skip to content

Adds title to the environments list in CI/CD Settings

Filipa Lacerda requested to merge 46806-env-table into 46806-typed-ci-variables

What does this MR do?

Adds a title row to the environments list in CI/CD settings.

Problem:

This list is built with haml and it's heavily manipulated by jQuery, updating this into a table requires a lot more effort than just HTML, we need to update a lot of JS. This JS is used in other places.

I'm hoping we can achieve a middle term solution, by adding a title row. This row will be hidden in the smaller viewport though, the -xs size, keeping the UX the list currently has on production.

mobile desktop
Screenshot_2019-04-30_at_12.11.35 Screenshot_2019-04-30_at_12.05.48

@rverissimo does this work as a middle term solution? In order to turn this into a proper table, we need quite a big refactor.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #46806 (closed)

Edited by Filipa Lacerda

Merge request reports