Skip to content

Only show author in autocomplete dropdown if author is active

Wei-Meng Lee requested to merge weimeng-user-autocomplete-fix into master

What does this MR do?

Currently, the assignee dropdown shows the issue/MR author as a choice even if their state is non-active (i.e. blocked, ldap_blocked). This bug was reported by a customer (Zendesk, internal use).

This MR adds a check to make sure the author is active before added it to the returned JSON.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Wei-Meng Lee

Merge request reports