Skip to content

Don't fail the job if the Review App doesn't deploy properly

Rémy Coutable requested to merge qa-fix-review-app-ping into master

What does this MR do?

It seems the deploy function causes the job to fail if it doesn't succeed (e.g. https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/194213999). That wasn't the intent as we want to curl the Review App after the deploy finished (even if it failed) because sometimes the Review App is just a bit long to be ready (that was implemented in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27134).

This change move the || true to just after the eval $HELM_CMD in deploy as I suspect putting it after the deploy call doesn't do what we want.

Edited by Rémy Coutable

Merge request reports