Skip to content

Fixes stylelint warnings in environments

Filipa Lacerda requested to merge 59903-env-css into master

What does this MR do?

Fixes stylelint warnings in environments:

  • Deletes unused CSS
  • Replaces CSS with some utility classes
  • Moves prometheus related CSS into a new file

Stylelint after this MR:

 yarn stylelint-file app/assets/stylesheets/pages/environments.scss
yarn run v1.12.3
$ node node_modules/stylelint/bin/stylelint.js app/assets/stylesheets/pages/environments.scss
✨  Done in 0.80s.
before after
Screenshot_2019-04-09_at_11.34.22 Screenshot_2019-04-09_at_11.23.21
Screenshot_2019-04-09_at_11.34.11 Screenshot_2019-04-09_at_11.23.32

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #59903 (closed)

Edited by Filipa Lacerda

Merge request reports