Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Moves domain setting to Clusters page
What does this MR do?
Moves 'domain' setting from Auto DevOps to Clusters page
EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9373
What are the relevant issue numbers?
Related to #52363 (closed)
Screenshots
Cluster page
On CE
Without ingress | With ingress |
---|---|
![]() |
![]() |
On EE
Without ingress | With ingress |
---|---|
![]() |
![]() |
Auto DevOps Page
CE & EE |
---|
![]() |
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24740 -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides - [-] Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
- [-] Security reports checked/validated by reviewer
Backend To do
-
Add domain
field to Clusters page -
Change domain text if the Cluster has Ingress installed -
Remove domain from Auto DevOps -
Inject KUBE_INGRESS_HOSTNAME
(along withAUTO_DEVOPS_DOMAIN
) environment variable if present. -
Migration -
Fix QA https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/152347852
Edited by Ash McKenzie
Merge request reports
Activity
Please register or sign in to reply