Skip per-commit validations which have already passed on another change/branch
What does this MR do?
Caches the result of validations per commit in order to avoid performing them if the commit is found in a different branch.
What are the relevant issue numbers?
Closes #44679 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
Security reports checked/validated by reviewer
Merge request reports
Activity
@jamedjo do you mind to take a look at this approach?
The caching mechanism could be improved to allocate less memory, but for
100000
commits we'd allocate 4MB and for1000000
32 approximately. I think we would reach first the request expiration because of theraw_deltas
funnel before this structure size becomes important.In case we could solve/enhance/improve the current
raw_deltas
funnel, we could use a reverse bloom filter to allocate the information into a bit array (but we'll need more computational time to find the object in the array).Edited by Francisco Javier Lópezassigned to @jamedjo
1 Warning The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge. Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 0bfc63ae - Removed clause that prevented validations if not lfs
- Resolved by Douwe Maan
assigned to @fjsanpedro
- Resolved by Douwe Maan
assigned to @jamedjo
assigned to @DouweM
- Resolved by Douwe Maan
- Resolved by Douwe Maan
assigned to @fjsanpedro
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Tests added for this feature/bug as completed
- Resolved by Douwe Maan
- Resolved by Douwe Maan
added 1 commit
- 3ba974e8 - Added caching for Change::Access diff validations
added 1 commit
- 87522992 - Added caching for Change::Access diff validations
@DouweM can you take another look? The only job failing is
danger-review
and was fixed in the last push.assigned to @DouweM
- Resolved by Douwe Maan
assigned to @fjsanpedro
added 1 commit
- 10921133 - Renamed process_raw_deltas to process_commits
assigned to @DouweM
enabled an automatic merge when the pipeline for 10921133 succeeds
mentioned in commit 08f86409
mentioned in issue gitlab-org/release/tasks#620 (closed)