Skip to content

Resolve "Navigating unresolved discussions on Merge Request page"

André Luís requested to merge 51122-fix-navigating-discussions into master

What does this MR do?

Updates logic to be able to navigate in discussions after we've introduced Incremental Rendering of Diff files.

Kapture_2018-11-03_at_21.34.32

How to test

An example of a test script to test locally:

  1. Import https://gitlab.com/leipert/test-project into your local env
  2. Open an MR with ~13,000 lines added.
  3. Go the the MR Changes tab, start a discussion on one file at the very top.
  4. Scroll down until you see collapsed files, expand and start a discussion on any one of its lines.
  5. do that a few more times.
  6. Reload the page.
  7. Try navigating discussions on Discussion tab and Changes tab.

Behaviour on collapsed files: when clicked on next discussion, browser scrolls to file, shows loading spinner, when loading is complete, jump to discussion.

What are the relevant issue numbers?

Closes #51122 (closed)

Does this MR meet the acceptance criteria?

Edited by André Luís

Merge request reports