Skip to content

Upgrade eslint to v5.x

Mike Greiling requested to merge upgrade-eslint into master

What does this MR do?

Upgrades eslint to v5.x and upgrades all corresponding eslint plugins and the base airbnb config along with it.

This upgrade is necessary as we have quickly been falling behind the latest eslint versions that our adopted config requires. We had previously been waiting for ignoreDestructuring property of the camelcase eslint rule to be adopted, and now that it exists we can upgrade without disabling this critical rule.

Original issue: https://github.com/eslint/eslint/pull/10373

The primary troublemaking rules in the course of the upgrade have been temporarily disabled within .eslintrc.yml. These should be re-instantiated as soon as possible, but they should be done one at a time so as not to overwhelm the reviewer.

The primary troublemaker which was impossible to deal with using a simple rule change was vue/attribute-order. Its behavior had changed in such a way that the only way to resolve it was to fix all of the violations or disable the rule entirely. I opted for the former, and that is primarily why there are a lot of line changes in this MR.

The only thing that changed were the ordering of a few custom attributes in our vue components.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Filipa Lacerda

Merge request reports