Skip to content
Snippets Groups Projects

Search for label on project labels page by title or description

Merged Dmytro Zaporozhets (DZ) requested to merge dz-labels-search into master
All threads resolved!

What does this MR do?

Adds ability to search for label on project labels page by title or description

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Its impossible to find a label on https://gitlab.com/gitlab-org/gitlab-ce/labels page as its 17 pages of them

Screenshots (if relevant)

no search

Screen_Shot_2018-07-28_at_14.06.21

nothing found

Screen_Shot_2018-07-28_at_14.13.48

priority and other label match

Screen_Shot_2018-07-28_at_14.06.18

only other label match

Screen_Shot_2018-07-28_at_14.06.14

only priority match

Screen_Shot_2018-07-28_at_14.06.11

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/34837, https://gitlab.com/gitlab-org/gitlab-ce/issues/27031

Edited by Matej Latin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 8ff07e17 - Move search param check into own method in app/finders/labels_finder.rb

    Compare with previous version

  • Dmytro Zaporozhets (DZ) resolved all discussions

    resolved all discussions

  • Dmytro Zaporozhets (DZ) marked the checklist item Conforms to the style guides as completed

    marked the checklist item Conforms to the style guides as completed

  • Dmytro Zaporozhets (DZ) marked the checklist item Conforms to the merge request performance guidelines as completed

    marked the checklist item Conforms to the merge request performance guidelines as completed

  • Dmytro Zaporozhets (DZ) marked the checklist item Has been reviewed by a Backend maintainer as completed

    marked the checklist item Has been reviewed by a Backend maintainer as completed

  • marked the checklist item Tests added for this feature/bug as completed

  • Dmytro Zaporozhets (DZ) marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Dmytro Zaporozhets (DZ) unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Dmytro Zaporozhets (DZ) changed the description

    changed the description

  • Dmytro Zaporozhets (DZ) changed the description

    changed the description

  • added 1 commit

    • 3d6794cc - Add more UI logic to label search functionality

    Compare with previous version

  • @matejlatin I updated MR description with new screenshots for different behavior. I believe it should be more user-friendly now

  • @dzaporozhets Only one suggestion for HAML, rest looks good. :thumbsup:

  • As an alternative, we can move a message that displayed only to maintainers to another block.

    @dzaporozhets I like this one the best :thumbsup:

    Is it possible to change the 'no results' texts? It's confusing that it says 'no labels found' in one section but then there are results in the other section. Can we say 'No prioritised labels found...' in the prioritised labels section and 'No other labels found...' in the other labels section?

  • @tauriedavis no worries, I'm glad to help out with anything search related :slight_smile:

  • I like this one the best :thumbsup:

    Cool, I will update UI then

    Can we say 'No prioritised labels found...' in the prioritised labels section and 'No other labels found...' in the other labels section?

    @matejlatin sure. Or maybe hide the whole section if no labels found in one?

  • @dzaporozhets I like to be very careful when it comes to hiding UI parts. Lack of presence of a certain UI can be confusing ('where are my prioritised labels?') while simply saying 'No results' is very clear.

    In this case, I think it's better if we keep the 'No results' messages present.

    Cool, I will update UI then

    Awesome, tnx :thumbsup:

  • mentioned in issue #34837 (closed)

  • added 1 commit

    • 861338d1 - Add more specs to labels search feature

    Compare with previous version

  • added 340 commits

    • 861338d1...02e35a0d - 326 commits from branch master
    • f42fe0b6 - Add ability to filter labels by title or description
    • 692d4795 - Add search form to project labels page
    • 85a8c7ef - Add feature specs for project labels search
    • cb328517 - Add changelog for label search feature
    • 4996876e - Add specs for label search backend code
    • bdb1f790 - Add locale entry for filtering by label sentence
    • 26b2790e - Improve labels search UI on project labels page
    • 4b1b6acf - Add no labels found block for project labels page
    • 8e8cb5b9 - Re-generate locale after text modification
    • c0bf3615 - Move search param check into own method in app/finders/labels_finder.rb
    • 300f6aba - Add more UI logic to label search functionality
    • f128cdb8 - Add more specs to labels search feature
    • 5137df53 - Make few minor styling changes to project labels page
    • d860cf0f - Show different not fount message for project labels search

    Compare with previous version

  • @matejlatin I made changes. here are some screenshots:

    Screen_Shot_2018-07-31_at_1.11.24_PM

    Screen_Shot_2018-07-31_at_1.11.20_PM

    Screen_Shot_2018-07-31_at_1.11.27_PM

    Screen_Shot_2018-07-31_at_1.11.31_PM

    I think its ready to merge once you approve UX

  • Dmytro Zaporozhets (DZ) resolved all discussions

    resolved all discussions

  • Dmytro Zaporozhets (DZ) marked the checklist item Has been reviewed by a Frontend maintainer as completed

    marked the checklist item Has been reviewed by a Frontend maintainer as completed

  • added 1 commit

    • e0a3701d - Update locale with labels search page strings

    Compare with previous version

  • added 1 commit

    • ac05ebc3 - Add frozen_string_literal to search_labels_spec.rb according to GitLab bot

    Compare with previous version

  • @dzaporozhets it looks good to me, thanks for making the changes :thumbsup:

  • Matej Latin marked the checklist item Has been reviewed by a UX Designer as completed

    marked the checklist item Has been reviewed by a UX Designer as completed

  • Victor Wu changed milestone to %11.2

    changed milestone to %11.2

  • @kushalpandya can you please approve the MR so I can merge?

  • @matejlatin great, thank you for the review!

  • @felipe_artur or maybe you can approve :)

  • Felipe Cardozo approved this merge request

    approved this merge request

  • mentioned in commit 9b433c37

  • mentioned in merge request !21480 (merged)

  • mentioned in issue #49695 (moved)

  • mentioned in issue gitlab#23468

  • Please register or sign in to reply
    Loading