Skip to content

Allow feature flag names to be a symbol

Douglas Barbosa Alexandre requested to merge da-feature-flags into master

What does this MR do?

Allow using symbols as feature flag key.

Why was this MR needed?

I made this mistake on https://gitlab.com/gitlab-org/gitlab-ee/issues/6964. We also have some mentions on our documentation that uses a symbol as the feature flag key, e.g., the Gitaly documentation mentions:

Feature.enable(:gitaly_feature_name)
Feature.disable(:gitaly_feature_name)

That's clearly wrong, and we should prevent people from making the same mistake. :)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/6964

Edited by Rémy Coutable

Merge request reports